Add V2 design for parser protocol and open_virtual_dataset #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #598 +/- ##
===========================================
+ Coverage 89.34% 89.57% +0.23%
===========================================
Files 34 37 +3
Lines 1943 1986 +43
===========================================
+ Hits 1736 1779 +43
Misses 207 207
🚀 New features to boost your workflow:
|
TomNicholas
reviewed
May 16, 2025
virtualizarr/v2/__init__.py
Outdated
There was a problem hiding this comment.
Why do we need a v2 namespace? Shouldn't we just be directly replacing the functions we already have?
There was a problem hiding this comment.
The purpose is to allow updating parsers incrementally, but no worries if you prefer to do it all in one go with Sean's branch.
There was a problem hiding this comment.
I would prefer to do it all in one go if we can!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following design structure in #568
Builds on changes in #595, which should be merged first.
Closes #553
Closes #245