Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BYOD Dataset Review
BYOD Dataset Information
Dataset High Level Information
Dataset owner information
What data is being provided?
asdfas
Where does this data come from?
asdf
Why do you need this data and how will you use it?
How do you plan on using this data?
asdf
How often will this data be queried?
fdsa
Is there any existing IA data that you would like to join this data on?
asdf
Dataset detailed information
What regions/cloud providers/datacenter will this data reside in?
fdsa
Will this dataset potentially need to be backfilled?
asdf
How often will the structure of this data change?
fasdf
What is the approximate size of the data?
asdfas
Data sensitivity and access control
What teams (other than the owner team) will need access to this data?
fdsa
Does the data constitute substantive “Customer Data” sent to Datadog for processing ?
asdf
Do you have a data deletion process? [Answer If your dataset DOES include Customer Data (answered yes above]
fdsa
Does the data contain usage data? (https://datadoghq.atlassian.net/wiki/spaces/IA/pages/2717450835/Usage+Data)?
asdf
Are any parts of the data region-restricted?
fdsa
Does this data contain any PII? (If yes, please add details)
fasdf
Review Checklist
For Dataset Owner/ PR Submitter
Go through the checklist and make sure you can check each box. We cannot merge the PR until each of these is done.
base_table_name
matches the file name and dataset name from descriptiondata.display_name
appropriately matchesdescription
is filled out and is a high level description of the dataset. Make sure that the description :region_restrictions
field matches answer to data being region restricted in PR descriptiondata.cloud_locations
is filled in for each DC you want data ingested fromfile_format
is accurate to the data being providedowner
,owner_slack_channel
match PR descriptionoptional_parameters
section is filled in if neededoptional_parameters.load_type
if this is not INSERToptional_parameters.date_partition_interval_hours
if this is not produced daily. Or put 24 to be explicit.table_columns
is filled out and matches the schema of the dataset in cloud storagedescription
. This description does not just repeat the column name, and it explicitly defines any acronyms or obscure terminology.For Internal Analytics
Go through the checklist and make sure you can check each box. We cannot merge the PR until each of these is done.
Dataset details review (IAX / IAD)
privacy-ops
) if any ofcontains_pii
,contains_customer_data
, orcontains_employee_data
are True. (If there are other sensitive aspects to the data beyond these questions, use your discretion of when to contact privacy.)BYOD technical review (IAI)
--test_run true
)