docs: dracut-crypt-ssh keys name and format fix #743
+23
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JkktBkkt
force-pushed
the
doc-pictures-on-my-mind
branch
from
6b24aab to
e7d0de6
Compare
ahesford
requested changes
Apr 30, 2025
|
|
||
| mkdir -p /etc/dropbear | ||
| for keytype in rsa ecdsa ed25519; do | ||
| ssh-keygen -g -N "" -m PEM -t "${keytype}" -f "/etc/dropbear/ssh_dracut_host_${keytype}_key" |
There was a problem hiding this comment.
Leave the output files named as the later directions require, rather than changing those as well.
Suggested change
| ssh-keygen -g -N "" -m PEM -t "${keytype}" -f "/etc/dropbear/ssh_dracut_host_${keytype}_key" | |
| ssh-keygen -g -N "" -m PEM -t "${keytype}" -f "/etc/dropbear/ssh_host_${keytype}_key" |
Comment on lines
-211
to
+223
| # Copy system keys for consistent access | ||
| dropbear_rsa_key=/etc/dropbear/ssh_host_rsa_key | ||
| dropbear_ecdsa_key=/etc/dropbear/ssh_host_ecdsa_key | ||
| # Point to host keys made earlier | ||
| dropbear_rsa_key=/etc/dropbear/ssh_dracut_host_rsa_key | ||
| dropbear_ecdsa_key=/etc/dropbear/ssh_dracut_host_ecdsa_key |
There was a problem hiding this comment.
Drop changes in light of edits above.
There was a problem hiding this comment.
Paraphrasing from irc for transparency:
Am unsure whether Copy system keys... line makes sense since we're not using our system keys in that case. This rename is the same reason I've changed the name above as, following the guide, the user makes separate keys just for dracut-included dropbear.
I'll add these in if you/team insist on this phrasing
Co-authored-by: Andrew J. Hesford <ajh@sideband.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on IRC, fixes the instructions for key creation for dracut-crypt-ssh module, preserving the instructions for mkinitcpio