No clue but try make stuff more thread safe

zbx1425 · Jan 17, 2025 · ef2daf9 · ef2daf9
1 parent 4405e88
commit ef2daf9
Showing 1 changed file with 27 additions and 19 deletions.
diff --git a/common/src/main/java/cn/zbx1425/worldcomment/data/persist/FileSerializer.java b/common/src/main/java/cn/zbx1425/worldcomment/data/persist/FileSerializer.java
@@ -59,33 +59,41 @@ private Path getLevelRegionPath(ResourceLocation dimension, ChunkPos region) {
     }
 
     public void insert(CommentEntry newEntry) throws IOException {
-        try {
-            Files.createDirectory(getLevelPath(newEntry.level));
-        } catch (FileAlreadyExistsException ignored) { }
-        Path targetFile = getLevelRegionPath(newEntry.level, newEntry.region);
-        try (FileOutputStream oStream = new FileOutputStream(targetFile.toFile(), true)) {
-            newEntry.writeFileStream(oStream);
+        synchronized (this) {
+            try {
+                Files.createDirectory(getLevelPath(newEntry.level));
+            } catch (FileAlreadyExistsException ignored) {
+            }
+            Path targetFile = getLevelRegionPath(newEntry.level, newEntry.region);
+            try (FileOutputStream oStream = new FileOutputStream(targetFile.toFile(), true)) {
+                newEntry.writeFileStream(oStream);
+            }
         }
     }
 
     public void update(CommentEntry existingEntry) throws IOException {
-        assert existingEntry.fileOffset > 0;
-        Path targetFile = getLevelRegionPath(existingEntry.level, existingEntry.region);
-        try (RandomAccessFile oStream = new RandomAccessFile(targetFile.toFile(), "rw")) {
-            existingEntry.updateInFile(oStream);
+        synchronized (this) {
+            assert existingEntry.fileOffset > 0;
+            Path targetFile = getLevelRegionPath(existingEntry.level, existingEntry.region);
+            try (RandomAccessFile oStream = new RandomAccessFile(targetFile.toFile(), "rw")) {
+                existingEntry.updateInFile(oStream);
+            }
         }
     }
 
     public void updateRegion(List<CommentEntry> regionEntries) throws IOException {
-        if (regionEntries.isEmpty()) return;
-        CommentEntry pivot = regionEntries.getFirst();
-        try {
-            Files.createDirectory(getLevelPath(pivot.level));
-        } catch (FileAlreadyExistsException ignored) { }
-        Path targetFile = getLevelRegionPath(pivot.level, pivot.region);
-        try (FileOutputStream oStream = new FileOutputStream(targetFile.toFile(), false)) {
-            for (CommentEntry entry : regionEntries) {
-                entry.writeFileStream(oStream);
+        synchronized (this) {
+            if (regionEntries.isEmpty()) return;
+            CommentEntry pivot = regionEntries.getFirst();
+            try {
+                Files.createDirectory(getLevelPath(pivot.level));
+            } catch (FileAlreadyExistsException ignored) {
+            }
+            Path targetFile = getLevelRegionPath(pivot.level, pivot.region);
+            try (FileOutputStream oStream = new FileOutputStream(targetFile.toFile(), false)) {
+                for (CommentEntry entry : regionEntries) {
+                    entry.writeFileStream(oStream);
+                }
             }
         }
     }