[ZEE-6082] Add specification to DataProduct #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurtemple
commented
Nov 28, 2024
| @@ -74,7 +108,9 @@ public boolean equals(Object o) { | |||
| DataProduct that = (DataProduct) o; | |||
| return Objects.equals(inputPorts, that.inputPorts) | |||
| && Objects.equals(outputPorts, that.outputPorts) | |||
| && Objects.equals(internalComponents, that.internalComponents); | |||
| && Objects.equals(internalComponents, that.internalComponents) | |||
There was a problem hiding this comment.
Je ne suis pas extrêmement fan de ces méthodes equals car elle ne comparent pas les champs du type parent.
There was a problem hiding this comment.
J'avais corrigé les classes Dataset, Vizualisation et DataProcess sur les fonctions equals, hashcode et toString mais j'ai oublié de passer sur les classes de DataProduct :/
There was a problem hiding this comment.
Je suis passé sur DataProduct.
arthurtemple
force-pushed
the
ZEE-6082/data-product-source
branch
from
f84f3c9 to
09dad17
Compare
martin-guerre
approved these changes
Nov 29, 2024
seblm
approved these changes
Nov 29, 2024
Comment on lines
14
to
18
| /** Enum representing the type of the data product. */ | ||
| public enum Type { | ||
| Custom, | ||
| DataProductSpecificationDotCom | ||
| } |
There was a problem hiding this comment.
Comme vu ensemble : cet enum n'est finalement pas utile.
arthurtemple
force-pushed
the
ZEE-6082/data-product-source
branch
from
09dad17 to
6bacb49
Compare
arthurtemple
changed the title
arthurtemple
force-pushed
the
ZEE-6082/data-product-source
branch
from
6bacb49 to
a081c64
Compare
arthurtemple
force-pushed
the
ZEE-6082/data-product-source
branch
from
a081c64 to
7ff9c17
Compare
martin-guerre
approved these changes
Dec 2, 2024
leborgneromain
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue: https://zeenea.atlassian.net/browse/ZEE-6082
PR summary:
specificationàDataProductChecklist for Developer:
Checklist for Reviewer