Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ZEE-6771] Add LabelIdentifier to Inventory #73

Merged
merged 3 commits into from
Feb 18, 2025
Merged

[ZEE-6771] Add LabelIdentifier to Inventory #73

merged 3 commits into from
Feb 18, 2025

Conversation

martin-guerre
Copy link
Contributor

@martin-guerre martin-guerre commented Feb 14, 2025 •
edited
Loading

JIRA issue: https://zeenea.atlassian.net/browse/ZEE-6771

PR summary:
  • Add LabelIdentifier to Inventory
  • This allow filtering on label keys in connector configuration with universal filters
  • Retro-compatibility is insure with custom label keys when using deprecated functions
Checklist for Developer:
  • Summary part has been documented
  • Reviewers have been requested
  • Reviews & comments have been taken into consideration
  • Commits have been reworded and history cleaned
Checklist for Reviewer
  • Code has been reviewed, commented and changes have been requested
  • Reviews & comments have been taken into consideration

@martin-guerre martin-guerre force-pushed the ZEE-6771/add_label_identifier_inventory branch from 1d3e1d2 to 15fc960 Compare February 14, 2025 14:38
arthurtemple
arthurtemple approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@arthurtemple arthurtemple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@martin-guerre
Copy link
Contributor Author

image

J'ai pas la ref xD

@arthurtemple
Copy link
Contributor

J'ai pas la ref xD

C'est un sport, qu'on applique également à des commits.

guillaume-yan
guillaume-yan reviewed Feb 17, 2025
View reviewed changes
Copy link

@guillaume-yan guillaume-yan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je me demande quand même si ce n'est pas l'occasion de passer à Lombok, on supprimerais énormément de code

@martin-guerre
Copy link
Contributor Author

@arthurtemple est-ce que les modifications apportées suite au retour de Guillaume te conviennent ?

@martin-guerre martin-guerre merged commit d88b7a0 into main Feb 18, 2025
3 checks passed
@martin-guerre martin-guerre deleted the ZEE-6771/add_label_identifier_inventory branch February 18, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthurtemple arthurtemple arthurtemple approved these changes

@tbouriaudZeenea tbouriaudZeenea tbouriaudZeenea approved these changes

@guillaume-yan guillaume-yan guillaume-yan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martin-guerre @arthurtemple @tbouriaudZeenea @guillaume-yan