-
Notifications
You must be signed in to change notification settings - Fork 1k
Gessnerfl/1009 modular maxwell #1011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gessnerfl
wants to merge
116
commits into
zendesk:master
Choose a base branch
from
gessnerfl:gessnerfl/1009_modular_maxwell
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Gessnerfl/1009 modular maxwell #1011
gessnerfl
wants to merge
116
commits into
zendesk:master
from
gessnerfl:gessnerfl/1009_modular_maxwell
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into corresponding package
…ootstrapperFactory.java
…ll producers to standalone
…line and environment from factory/configuration itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first draft of how #1009 can be implemented. It uses the spring framework for dependency injection as it allows inversion of control and with this a simple modular design.
the standalone application represents the original maxwell.
There are spring auto configurations for spring boot. The standalone application is not using spring boot to avoid unnecessary dependencies.