Filter column names fix #1253
Open
Filter column names fix #1253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 20, 2019 14:58
…y using the original column names, instead of lower case version, when getting table's column list from TableColumnList class. The column list is used in Filter.couldIncludeFromColumnFilters() method and only there, which forces the method to always use lower case version of the column. On the other hand, the Filter.includes() method uses the original column names as reported by "RowMap.getData()" method. This leads to inconsistent syntex requirement for the filters, which in turn brakes column based filtering.
…y using the original column names, instead of lower case version, when getting table's column list from TableColumnList class. The column list is used in Filter.couldIncludeFromColumnFilters() method and only there, which forces the method to always use lower case version of the column. On the other hand, the Filter.includes() method uses the original column names as reported by "RowMap.getData()" method. This leads to inconsistent syntex requirement for the filters, which in turn brakes column based filtering.
…ski/maxwell into filter_column_names_fix
|
Hi. Column names are not case sensitive anywhere in mysql, so I think a better fix here would be to lower-case the column names whenever we're using them in the filter. |
|
Hi, OK I will into it today and change the MR. Thanks for the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix column based filters (either by column name or by column value) by using the original column names, instead of lower case version, when getting table's column list from TableColumnList class. The column list is used in Filter.couldIncludeFromColumnFilters() method and only there, which forces the method to always use lower case version of the column. On the other hand, the Filter.includes() method uses the original column names as reported by "RowMap.getData()" method. This leads to inconsistent syntex requirement for the filters, which in turn brakes column based filtering.