Skip to content

stop pushing maxwell.bootstrap table events #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DPGrev
Copy link
Contributor

@DPGrev DPGrev commented Nov 21, 2019

As discussed in: #1386

@osheroff
Copy link
Collaborator

bunch of failing tests. most tests just need to be untrained to expect this row, but there's also a weird one:

Running com.zendesk.maxwell.BootstrapIntegrationTest
java.sql.SQLException: Zero date value prohibited
	at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:129)
	at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:97)
	at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:89)
	at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:63)
	at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:73)
	at com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException(SQLExceptionsMapping.java:99)
	at com.mysql.cj.jdbc.result.ResultSetImpl.getDate(ResultSetImpl.java:740)
	at com.mysql.cj.jdbc.result.ResultSetImpl.getObject(ResultSetImpl.java:1236)
	at com.zendesk.maxwell.bootstrap.SynchronousBootstrapper.setRowValues(SynchronousBootstrapper.java:208)
	at com.zendesk.maxwell.bootstrap.SynchronousBootstrapper.performBootstrap(SynchronousBootstrapper.java:69)
	at com.zendesk.maxwell.bootstrap.SynchronousBootstrapper.startBootstrap(SynchronousBootstrapper.java:39)
	at com.zendesk.maxwell.bootstrap.BootstrapController.work(BootstrapController.java:65)
	at com.zendesk.maxwell.util.RunLoopProcess.runLoop(RunLoopProcess.java:34)
	at com.zendesk.maxwell.MaxwellContext.lambda$getBootstrapController$0(MaxwellContext.java:395)

@DPGrev
Copy link
Contributor Author

DPGrev commented Nov 25, 2019

I will look into it

@DPGrev
Copy link
Contributor Author

DPGrev commented Nov 25, 2019

Fixed!

@osheroff
Copy link
Collaborator

osheroff commented Dec 7, 2019

are you sure this change actually removed the row?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants