Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

record preview: display communities list #726

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

anikachurilova
Copy link
Contributor

@anikachurilova anikachurilova commented Feb 15, 2024

Needs: #698

Preview:
Screenshot 2024-02-15 at 16 25 05

Screenshot 2024-02-15 at 16 26 06

Also used in frontpage:
Screenshot 2024-02-15 at 16 30 56

{# Communities list #}
<h5>
{% set communities_entries = record.parent.communities.entries %}
<b>{{ _("Part of:")}} {{ communities_list(communities=communities_entries) }}</b>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spoke with Lars and decided to use "Part of" in stead of "Published in", because this phrasing is already used in displaying Journal info (see screenshots)

<a
class="community-link"
href="/communities/{{ community.slug }}"
title="{{ community_title }}: {{_('Search')}}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just for my education: what does the title attr do? I never used it with a tag like this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little gray tooltip like this:
Screenshot 2024-02-16 at 09 22 21

@anikachurilova anikachurilova force-pushed the add-communities-list branch 2 times, most recently from c49665d to 66c978e Compare February 16, 2024 14:27
@slint slint merged commit 1ef6718 into zenodo:master Feb 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add "Published in" on the search page
3 participants