drivers: sensor: pzem004t: add pzem004t AC parameter sensor driver #89123
+512
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
asemjonovs,
avisconti,
decsny,
galak,
jeppenodgaard,
MaureenHelm,
rruuaanng,
teburd,
tristan-google,
ubieda and
yperess
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new sensor driver for the Peacefair PZEM004T multifunction AC parameter sensor. Key changes include:
- New header files defining sensor channels, attributes, and driver configuration.
- Device Tree binding files to support the new sensor.
- Implementation of the sensor driver with functions for initialization, data sampling, attribute get/set, and optional energy reset.
Reviewed Changes
Copilot reviewed 5 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| include/zephyr/drivers/sensor/pzem004t.h | Defines sensor channels and attributes for the new sensor driver. |
| dts/bindings/vendor-prefixes.txt | Adds vendor prefix for Peacefair. |
| dts/bindings/sensor/peacefair,pzem004t.yaml | Provides DTS binding for the sensor device. |
| drivers/sensor/pzem004t/pzem004t.h | Declares register addresses, lengths, scaling factors, and data structures. |
| drivers/sensor/pzem004t/pzem004t.c | Implements the sensor driver with init, sample fetch, and attribute functions. |
Files not reviewed (6)
- drivers/sensor/CMakeLists.txt: Language not supported
- drivers/sensor/Kconfig: Language not supported
- drivers/sensor/pzem004t/CMakeLists.txt: Language not supported
- drivers/sensor/pzem004t/Kconfig: Language not supported
- tests/drivers/build_all/sensor/app.overlay: Language not supported
- tests/drivers/build_all/sensor/uart.dtsi: Language not supported
Comments suppressed due to low confidence (1)
dts/bindings/sensor/peacefair,pzem004t.yaml:18
- Typo detected: 'snsor_attr_set' should be corrected to 'sensor_attr_set'.
after which multiple devices with different addresses can be connected and snsor_attr_set has to be used for each device
srishtik2310
force-pushed
the
add_pzem004t_sensor_driver_support
branch
from
645c545 to
7d55f13
Compare
Adds driver for Peacefair pzem004t multifunction AC parameter sensor. Signed-off-by: Srishtik Bhandarkar <srishtik.bhandarkar2000@gmail.com>
srishtik2310
force-pushed
the
add_pzem004t_sensor_driver_support
branch
from
7d55f13 to
54194cb
Compare
|
I have made the changes suggested in review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds driver for Peacefair pzem004t multifunction AC parameter sensor.