fixup! Release 17.0.0-0

tests/integration/components/dropdown/index/focus-test.gjs

@@ -137,7 +137,9 @@ module('dropdownx (focus)', function (hooks) {
     assert.expect(2);
 
     // we use do not employ any methods to prevent
-    // keyboard-focusable-scrollers from taking affect.
+    // keyboard-focusable-scrollers from taking affect
+    // this allows focus to move to the dropdown content
+    // when it is overflowing.
 
     let event;
 

tests/integration/components/select-box/index/focus-test.gjs

@@ -561,7 +561,7 @@ module('select-box (focus)', function (hooks) {
     await render(<template>
       {{! template-lint-disable no-forbidden-elements }}
       <style>
-        .select-box__trigger:focus-visible { outline: 2px solid red; }
+        .dropdown__trigger:focus-visible { outline: 2px solid red; }
       </style>
       <SelectBox @value="foo" as |sb|>
         <sb.Dropdown>
@@ -623,14 +623,20 @@ module('select-box (focus)', function (hooks) {
   });
 
   test('keyboard-focusable-scrollers fix', async function (assert) {
-    assert.expect(1);
+    assert.expect(2);
 
-    // we use tabindex="-1" on the listbox to prevent
+    // we use tabindex="-1" on the dropdown content to prevent
     // keyboard-focusable-scrollers from stealing focus, but
     // this has a down side of actually allowing the listbox
     // to be focusable on click, so we must prevent that.
+    //
     // https://issues.chromium.org/issues/376718258
     // https://bugzilla.mozilla.org/show_bug.cgi?id=1930662
+    //
+    // here, when the primary interactive element is focused,
+    // and the user presses tab, we always want focus to move
+    // to the next interactive element. skipping the overflowing
+    // dropdown content.
 
     let event;
 
@@ -651,6 +657,7 @@ module('select-box (focus)', function (hooks) {
     await click('.select-box .dropdown__trigger');
     await click('.select-box__options');
 
+    assert.dom('.dropdown__content').hasAttribute('tabindex', '-1');
     assert.true(event.defaultPrevented);
   });
 });