Skip to content

Commit

Permalink
fixup! add dropdown primitive ctd
Browse files Browse the repository at this point in the history
  • Loading branch information
amk221 committed Dec 11, 2024
1 parent e406bc8 commit 5ffd644
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -318,14 +318,14 @@ module('select-box (down arrow key)', function (hooks) {
.hasAttribute('aria-current', 'true', 'the selected option is active');
});

test('down on input will open combobox', async function (assert) {
test('down on input will not open combobox', async function (assert) {
assert.expect(2);

// We can assume a Trigger is for opening/closing.
// But if there's a dropdown and no trigger, then its
// probably a custom select box, and we make no assumptions
// The developer should probably just render both an input
// and a trigger.
// The developer might want to open after a search has finished
// for example.

await render(<template>
<SelectBox as |sb|>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -319,8 +319,8 @@ module('select-box (up arrow key)', function (hooks) {
// We can assume a Trigger is for opening/closing.
// But if there's a dropdown and no trigger, then its
// probably a custom select box, and we make no assumptions
// The developer should probably just render both an input
// and a trigger.
// The developer might want to open after a search has finished
// for example.

await render(<template>
<SelectBox as |sb|>
Expand Down

0 comments on commit 5ffd644

Please sign in to comment.