fix internal order of options when used with #in-element

zestia · Jan 21, 2025 · 6e46e4b · 6e46e4b
1 parent a8599eb
commit 6e46e4b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## 17.1.1
+
+- Fix internal order of options when used with `#in-element`
+
 ## 17.1.0
 
 - Add `@destination` argument to dropdown content

diff --git a/addon/components/select-box/index.gjs b/addon/components/select-box/index.gjs
@@ -168,7 +168,9 @@ export default class SelectBox extends Component {
   }
 
   get optionElements() {
-    return [...this.element.querySelectorAll('.select-box__option')];
+    return this.optionsElement
+      ? [...this.optionsElement.querySelectorAll('.select-box__option')]
+      : [];
   }
 
   get interactiveElement() {

diff --git a/tests/integration/components/select-box/index/in-element-test.gjs b/tests/integration/components/select-box/index/in-element-test.gjs
@@ -10,7 +10,7 @@ module('select-box (in-element)', function (hooks) {
   const destination = () => find('.destination');
 
   test('a common scenario of rendering a dropdown in an external element works', async function (assert) {
-    assert.expect(6);
+    assert.expect(7);
 
     await render(<template>
       {{! template-lint-disable no-unnecessary-curly-strings }}