Skip to content

Commit

Permalink
[Content] SEO Tab width and card header text update (#2982)
Browse files Browse the repository at this point in the history
  • Loading branch information
finnar-bin authored Sep 27, 2024
1 parent f7064e2 commit 1f71116
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 12 deletions.
10 changes: 5 additions & 5 deletions src/apps/content-editor/src/app/views/ItemCreate/ItemCreate.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -379,15 +379,16 @@ export const ItemCreate = () => {
isLoading={saving || isPublishing || isLoadingNewItem}
isDirty={item?.dirty}
/>
<Stack
<Box
display="grid"
gridTemplateColumns="1fr minmax(0px, 40%)"
component="main"
className={styles.ItemCreate}
bgcolor="grey.50"
alignItems="center"
direction="row"
gap={4}
>
<Box width="60%" minWidth={640} height="100%">
<Box minWidth={640} height="100%">
{saveClicked && (hasErrors || hasSEOErrors) && (
<Box mb={3}>
<FieldError
Expand Down Expand Up @@ -431,7 +432,6 @@ export const ItemCreate = () => {
position="sticky"
top={0}
alignSelf="flex-start"
width="40%"
maxWidth={620}
>
{model?.type !== "dataset" && (
Expand Down Expand Up @@ -470,7 +470,7 @@ export const ItemCreate = () => {
)}
</Box>
</ThemeProvider>
</Stack>
</Box>
</Stack>
{isScheduleDialogOpen && !isLoadingNewItem && (
<SchedulePublish
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export const WordCount = ({
/>
<Box flex={1}>
<Typography variant="body2" color="text.secondary">
Non Common Words
Non Filler Words
</Typography>
<Typography variant="h4" color="text.primary" fontWeight={600}>
{totalUniqueNonCommonWords}
Expand Down
11 changes: 5 additions & 6 deletions src/apps/content-editor/src/app/views/ItemEdit/Meta/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -398,8 +398,9 @@ export const Meta = forwardRef(

return (
<ThemeProvider theme={theme}>
<Stack
direction="row"
<Box
display="grid"
gridTemplateColumns="1fr minmax(auto, 40%)"
gap={4}
bgcolor="grey.50"
pt={2.5}
Expand All @@ -411,7 +412,7 @@ export const Meta = forwardRef(
overflowY: "auto",
}}
>
<Stack flex={1} gap={4} width="60%" minWidth={640}>
<Stack flex={1} gap={4} minWidth={640}>
<Stack gap={3}>
{!!errorComponent && errorComponent}
<Box>
Expand Down Expand Up @@ -557,8 +558,6 @@ export const Meta = forwardRef(
</Stack>
{!isCreateItemPage && (
<Box
width="40%"
flex={1}
position="sticky"
top={0}
pb={2.5}
Expand All @@ -578,7 +577,7 @@ export const Meta = forwardRef(
</Box>
</Box>
)}
</Stack>
</Box>
</ThemeProvider>
);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ export const hasErrors = (errors: Error) => {
export const validateMetaDescription = (value: string) => {
let message = "";

if (!value) return message;

if (!(value.indexOf("\u0152") === -1)) {
message =
"Found OE ligature. These special characters are not allowed in meta descriptions.";
Expand Down

0 comments on commit 1f71116

Please sign in to comment.