Skip to content

Commit

Permalink
Fix/table sort by display date field by accounting for empty date val…
Browse files Browse the repository at this point in the history
…ues (#2864)

Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
  • Loading branch information
agalin920 and shrunyan authored Jul 23, 2024
1 parent 4d91e56 commit dc88b71
Showing 1 changed file with 10 additions and 3 deletions.
13 changes: 10 additions & 3 deletions src/apps/content-editor/src/app/views/ItemList/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -334,9 +334,16 @@ export const ItemList = () => {
: b.data[sort] - a.data[sort];
}
if (dataType === "date" || dataType === "datetime") {
return (
new Date(b.data[sort]).getTime() - new Date(a.data[sort]).getTime()
);
if (!a.data[sort]) {
return 1;
} else if (!b.data[sort]) {
return -1;
} else {
return (
new Date(b.data[sort]).getTime() -
new Date(a.data[sort]).getTime()
);
}
}
const aValue =
dataType === "images" ? a.data[sort]?.filename : a.data[sort];
Expand Down

0 comments on commit dc88b71

Please sign in to comment.