Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WYSIWYG/TinyMCE enhancements #2341

Merged
merged 200 commits into from
Jan 25, 2024
Merged

WYSIWYG/TinyMCE enhancements #2341

merged 200 commits into from
Jan 25, 2024

Conversation

finnar-bin
Copy link
Contributor

@finnar-bin finnar-bin commented Nov 28, 2023

Requires this pr to be merged first: zesty-io/design-system#213

wysiwyg.webm

Closes #2312

@zcolah
Copy link

zcolah commented Jan 8, 2024

Bug with aspect ratio locking:
https://www.loom.com/share/602d570aa20f44baa263f4d222a63a2e

@zcolah
Copy link

zcolah commented Jan 12, 2024

A few tiny concerns to resolve:

    • Enhancement: The Enter Key on the keyboard should trigger the Save Button on the Resize Image Modal
    • Bug: Make the width and height inputs only support numeric values. They should not accept special characters or alphabets.
  1. See Loom video for requests 2 and 3: https://www.loom.com/share/f0e3f7a4124742629aa295d17d8eaa58?from_recorder=1&focus_title=1

@shrunyan
Copy link
Contributor

@theofficialnar I'm seeing performance issues with typing. It is slow to show the characters as a I type them.

List text styling differs from body copy. This seems unintentional.
image

@finnar-bin
Copy link
Contributor Author

finnar-bin commented Jan 15, 2024

@theofficialnar I'm seeing performance issues with typing. It is slow to show the characters as a I type them.

@shrunyan this seems to be what we've discussed a while back with all of the field components re-rendering every time a user types, causing the lag. This is specially noticeable on content items with lots of fields, I see this happen even on prod as well. Do you reckon this is something worth fixing on this project or in a new one as I think the solution to this involves some major component re-composition and is not specific to the tinymce editor since all other input fields lag as well.

@shrunyan
Copy link
Contributor

@theofficialnar I retested and see as you've explained this performance concern being present across environments. With that being the case not lets not hold up this body of work. Please do prioritize fixing the performance concerns but do so on a separate branch.

@finnar-bin
Copy link
Contributor Author

@theofficialnar I retested and see as you've explained this performance concern being present across environments. With that being the case not lets not hold up this body of work. Please do prioritize fixing the performance concerns but do so on a separate branch.

Created a separate issue to track it and will start working on it asap
#2463

@finnar-bin finnar-bin added the ready PR is complete and ready for deployment label Jan 22, 2024
@zcolah zcolah added the annoucement Requires publishing in-app announcement label Jan 25, 2024
@zcolah
Copy link

zcolah commented Jan 25, 2024

@shrunyan shrunyan merged commit 823737c into master Jan 25, 2024
1 check failed
@shrunyan shrunyan deleted the enhancement/wysiwyg-updates branch January 25, 2024 20:12
@finnar-bin finnar-bin linked an issue Jan 26, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
annoucement Requires publishing in-app announcement enhancement Improvement to an existing feature ready PR is complete and ready for deployment vqa VQA is complete and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content: Update WYSIWYG to latest version of Tiny MCE Content: WYSIWYG Revamp
4 participants