Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various media bug fixes #2407

Merged
merged 4 commits into from
Dec 27, 2023
Merged

Various media bug fixes #2407

merged 4 commits into from
Dec 27, 2023

Conversation

finnar-bin
Copy link
Contributor

@finnar-bin finnar-bin commented Dec 19, 2023

NOTE: Needs zesty-io/material#83 for the alert color updates to take effect

Closes #2387
Closes #2378
Closes #2390

media-fixes.webm

@finnar-bin finnar-bin added the bug Something isn't working label Dec 19, 2023
@finnar-bin finnar-bin requested a review from agalin920 December 19, 2023 03:40
@finnar-bin finnar-bin self-assigned this Dec 19, 2023
@@ -381,9 +382,20 @@ export const OTFEditor = ({
},
}}
/>
<Alert severity="info" sx={{ mt: 2 }}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theofficialnar we should continue to use the alert component but just update its styling at a theme level.

Cc: @zcolah

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, created PR for theme-level update
zesty-io/material#83

Copy link
Contributor

@agalin920 agalin920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@finnar-bin finnar-bin requested a review from agalin920 December 19, 2023 07:03
@zcolah zcolah added the vqa VQA is complete and approved label Dec 20, 2023
@shrunyan shrunyan merged commit 77c61de into master Dec 27, 2023
1 check failed
@shrunyan shrunyan deleted the fix/various-media-bug-fixes branch December 27, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vqa VQA is complete and approved
Projects
None yet
4 participants