Remove content item data keys that are no longer valid when item is being created #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agalin920
changed the title
|
@agalin920 how does this interact with prior versions which contain the prior field name? |
|
@shrunyan This code only affects content item creation not edit so versions are not applicable. When creating a content item it gets 'staged' into indexedDB so it could save keyA but then a user can subsequently delete keyA in the model but going back to item create it will load the 'staged' item from indexedDB which will still have keyA and attempt to create the content item with that keyA which causes the API to fail |
|
@shrunyan for edit it seems like the BE handles making sure the content item is updated when model field name is updated including previous versions |
shrunyan
approved these changes
Jan 17, 2024
shrunyan
deleted the
2440-content-cannot-create-a-new-item-once-a-fields-api-id-is-updated
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ticket for better context