Resolve SEO fields lag #2445
Merged
Resolve SEO fields lag #2445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agalin920
reviewed
Jan 10, 2024
Comment on lines
16
to
22
| useDebounce( | ||
| () => { | ||
| onChange(value, "metaLinkText"); | ||
| }, | ||
| 250, | ||
| [value] | ||
| ); |
There was a problem hiding this comment.
I feel like the debounce is a hacky way to speed up performance because all that is being done is delaying computations, it doesn't really touch on the underlying issue which is that way too much is being re-rendered.
Is there truly a need for this debounce that cannot be solved be recomposition? Or is recomposing too large of a scope?
There was a problem hiding this comment.
@agalin920 Updated, figured out there were some components re-rendering due to unnecessary dependencies
agalin920
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seo-fields-lag.webm
Closes #2412