Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add media field thumbnails #2453

Merged
merged 14 commits into from
Feb 2, 2024
Merged

Add media field thumbnails #2453

merged 14 commits into from
Feb 2, 2024

Conversation

finnar-bin
Copy link
Contributor

file-type-thumbs.webm

Closes #2448

@finnar-bin finnar-bin added the bug Something isn't working label Jan 16, 2024
@finnar-bin finnar-bin self-assigned this Jan 16, 2024
@shrunyan shrunyan requested a review from agalin920 January 16, 2024 19:26
@agalin920
Copy link
Contributor

@theofficialnar Would it make more sense to use the existing FileTypePreview component here?

@finnar-bin
Copy link
Contributor Author

@agalin920 going to look into that

@finnar-bin
Copy link
Contributor Author

@agalin920 Updated to use FileTypePreview as suggested

Copy link

@zcolah zcolah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@zcolah zcolah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2024-01-30 at 04 34 32

@zcolah zcolah added the vqa VQA is complete and approved label Jan 30, 2024
@finnar-bin finnar-bin added the ready PR is complete and ready for deployment label Jan 31, 2024
@shrunyan shrunyan merged commit f145d52 into master Feb 2, 2024
1 check failed
@shrunyan shrunyan deleted the fix/2248-media-field-thumbnails branch February 2, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PR is complete and ready for deployment vqa VQA is complete and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content: Media Field - File Thumbnails not loading (except for images)
4 participants