Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Global Nav: Bug Fixes #2558

Merged
merged 2 commits into from
Feb 28, 2024
Merged

fix: Global Nav: Bug Fixes #2558

merged 2 commits into from
Feb 28, 2024

Conversation

glespinosa
Copy link
Contributor

@glespinosa glespinosa commented Feb 19, 2024 •
edited
Loading

image

@glespinosa glespinosa marked this pull request as ready for review February 19, 2024 23:34
@glespinosa glespinosa self-assigned this Feb 19, 2024
@glespinosa glespinosa added the ready PR is complete and ready for deployment label Feb 22, 2024
@glespinosa glespinosa marked this pull request as draft February 22, 2024 04:24
@glespinosa glespinosa changed the title fix: Global: Add 16px Right Margin to the Notification Aside Container fix: Global Nav: Bug Fixes Feb 22, 2024
@glespinosa glespinosa linked an issue Feb 22, 2024 that may be closed by this pull request
Global Nav: Bug Fixes #2498
Closed
3 tasks
@glespinosa
Copy link
Contributor Author

The cause of the scrollbar is because of the paddingY of 20px, changing to 16px solve the remaining issues
image

@glespinosa glespinosa marked this pull request as ready for review February 22, 2024 04:47
@zcolah zcolah added the vqa VQA is complete and approved label Feb 28, 2024
@shrunyan shrunyan merged commit 64a3e1d into master Feb 28, 2024
1 check failed
@shrunyan shrunyan deleted the fix/adjust-aside-notif branch February 28, 2024 19:40
This was referenced Mar 27, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agalin920 agalin920 agalin920 approved these changes

@finnar-bin finnar-bin finnar-bin approved these changes

Assignees

@glespinosa glespinosa

Labels
ready PR is complete and ready for deployment vqa VQA is complete and approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Global Nav: Bug Fixes
5 participants
@glespinosa @agalin920 @finnar-bin @shrunyan @zcolah