Prevent verify from invalidating stores #2564
Conversation
| @@ -44,6 +45,12 @@ export const GlobalAccountMenu: FC<GlobalAccountMenuProps> = ({ | |||
|
|
|||
| const dispatch = useDispatch(); | |||
|
|
|||
| useEffect(() => { | |||
| if (!auth.valid) { | |||
| onClose(); | |||
There was a problem hiding this comment.
Can you explain why this is needed? Is this due to the logOut? Shouldnt we simply call onClose on the logOut handleClickAction?
There was a problem hiding this comment.
@agalin920 This makes sure that it only closes the global accounts menu once the user has been successfully logged out instead of it immediately closing and then there's a brief moment where nothing happens while waiting for the api call to resolve.
There was a problem hiding this comment.
Mmm not sure if having a brief moment where nothing happens while it is open is any better than closing it and having a brief delay. At least having it close makes it seem the action went off as opposed to clicking it multiple times thinking it didnt go through.
verify-fix.webm