Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage Release #2821

Merged
merged 22 commits into from
Jul 19, 2024
Merged

Stage Release #2821

merged 22 commits into from
Jul 19, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Created by Github action

@agalin920 agalin920 enabled auto-merge (rebase) July 17, 2024 02:36
finnar-bin and others added 6 commits July 17, 2024 22:52
closes #2804

---------

Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Fixes #2826 
Fixes #2820 

Makes sure that the error blurb is shown when the save button is clicked
and there are field errors


https://github.com/user-attachments/assets/823b064c-b9ae-4f67-928b-77c63e5892f8
Will close: #2580

As a solution for the issue above. I make sure that when an item is a
child it should not be in a list where we can set a model parent.

To show how it resolves the issue. I set the parent of testDataSet to
testPage, then go to testPage to try check if testDataSet is present as
a model parent in the list which is not.


[screencast-8-9099fdbffb-hsbtls.manager.dev.zesty.io_8080-2024.07.17-20_39_01.webm](https://github.com/user-attachments/assets/3d179fd3-484f-456e-a9a9-5c7798e6b1e9)
auto-merge was automatically disabled July 19, 2024 16:42

Rebase failed

@shrunyan shrunyan merged commit caf522f into stage Jul 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants