-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stage Release #2821
Merged
Stage Release #2821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ <img width="597" alt="Screenshot 2024-07-12 at 7 37 56 PM" src="https://github.com/user-attachments/assets/f44d404e-f024-4284-9e12-2abd5ac0a3e0"> ](url)
Resolves #2722  --------- Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
…tionship fields (#2846)
closes #2804 --------- Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Fixes #2826 Fixes #2820 Makes sure that the error blurb is shown when the save button is clicked and there are field errors https://github.com/user-attachments/assets/823b064c-b9ae-4f67-928b-77c63e5892f8
Will close: #2580 As a solution for the issue above. I make sure that when an item is a child it should not be in a list where we can set a model parent. To show how it resolves the issue. I set the parent of testDataSet to testPage, then go to testPage to try check if testDataSet is present as a model parent in the list which is not. [screencast-8-9099fdbffb-hsbtls.manager.dev.zesty.io_8080-2024.07.17-20_39_01.webm](https://github.com/user-attachments/assets/3d179fd3-484f-456e-a9a9-5c7798e6b1e9)
auto-merge was automatically disabled
July 19, 2024 16:42
Rebase failed
shrunyan
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by Github action