Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage Release #3171

Merged
merged 1 commit into from
Jan 27, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"start:stage": "npm run serve:webpack -- --node-env stage --mode=development",
"task:clean": "rimraf build",
"task:webpack": "cross-env NODE_OPTIONS='--max_old_space_size=4096' webpack --progress --config src/shell/webpack.config.js",
"test": "./node_modules/.bin/cypress run --headless --browser chrome --reporter list",
"test": "./node_modules/.bin/cypress run --headless --browser electron --reporter list",
"test:open": "./node_modules/.bin/cypress open"
},
"dependencies": {
Expand Down
3 changes: 2 additions & 1 deletion src/apps/active-preview/Preview.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import {
ZoomInRounded,
DangerousRounded,
} from "@mui/icons-material";
import { useLocalStorage } from "react-use";

// import { Meta } from "./components/Meta";
import { JSONPreview } from "./components/JSONPreview";
Expand Down Expand Up @@ -87,7 +88,7 @@ export function Preview(props) {
const [anchorEl, setAnchorEl] = useState(null);
const [scaleAnchorEl, setScaleAnchorEl] = useState(null);
const [saving, setSaving] = useState(false);
const [zoom, setZoom] = useState(() => {
const [zoom, setZoom] = useLocalStorage("zoom", () => {
return isInIframe() ? 0.35 : 1;
});
const [hasErrors, setHasErrors] = useState(false);
Expand Down
9 changes: 8 additions & 1 deletion src/apps/blocks/components/CreateVariantDialog.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useState } from "react";
import { KeyboardEvent, useState } from "react";
import {
Box,
Button,
Expand Down Expand Up @@ -64,6 +64,12 @@ export const CreateVariantDialog = ({
onClose();
};

const handleKeyDown = (event: KeyboardEvent<HTMLDivElement>) => {
if (event.key === "Enter") {
handleVariantCreate();
}
};

return (
<Dialog open onClose={onClose} fullWidth maxWidth="xs">
<DialogTitle>
Expand Down Expand Up @@ -92,6 +98,7 @@ export const CreateVariantDialog = ({
fullWidth
data-cy="variant-name-input"
onFocus={(evt) => evt.target.select()}
onKeyDown={handleKeyDown}
/>
</DialogContent>
<DialogActions>
Expand Down
22 changes: 15 additions & 7 deletions src/apps/schema/src/app/components/CreateModelDialogue.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ export const CreateModelDialogue = ({ onClose, modelType = "" }: Props) => {
const [type, setType] = useState(modelType);
const dispatch = useDispatch();
const history = useHistory();
const { pathname } = useLocation();
const [model, updateModel] = useReducer(
(prev: Partial<ContentModel>, next: any) => {
const newModel = { ...prev, ...next };
Expand All @@ -105,7 +104,7 @@ export const CreateModelDialogue = ({ onClose, modelType = "" }: Props) => {
type: modelType,
description: "",
parentZUID: null,
listed: true,
listed: modelType === "block" ? false : true,
}
);

Expand Down Expand Up @@ -206,9 +205,7 @@ export const CreateModelDialogue = ({ onClose, modelType = "" }: Props) => {
useEffect(() => {
// Only navigate to schema page once initial content is created for templateset & og_image field is created for block
if ((isContentItemCreated || isOgImageFieldCreated) && createModelData) {
history.push(
`/${pathname?.split("/")?.[1] || "schema"}/${createModelData.data.ZUID}`
);
history.push(`/schema/${createModelData.data.ZUID}`);
onClose();
}
}, [isContentItemCreated, createModelData, isOgImageFieldCreated]);
Expand Down Expand Up @@ -282,7 +279,18 @@ export const CreateModelDialogue = ({ onClose, modelType = "" }: Props) => {
data-cy={`model-type-${modelType.key}`}
selected={type === modelType.key}
key={modelType.key}
onClick={() => setType(modelType.key)}
onClick={() => {
setType(modelType.key);
if (modelType.key === "block") {
updateModel({
listed: false,
});
} else {
updateModel({
listed: true,
});
}
}}
sx={{
borderRadius: "8px",
borderStyle: "solid",
Expand Down Expand Up @@ -492,7 +500,7 @@ export const CreateModelDialogue = ({ onClose, modelType = "" }: Props) => {
<Box display="flex" gap={1}>
<Checkbox
sx={{ width: "24px", height: "24px" }}
defaultChecked
checked={!!model?.listed}
onChange={(event) =>
updateModel({ listed: event.target.checked })
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ export const DuplicateModelDialogue = ({ onClose, model }: Props) => {
<Box display="flex" gap={1}>
<Checkbox
sx={{ width: "24px", height: "24px" }}
defaultChecked
checked={!!model?.listed}
onChange={(event) =>
updateNewModel({ listed: event.target.checked })
}
Expand Down
16 changes: 10 additions & 6 deletions src/apps/schema/src/app/views/AllModels.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,8 @@ export const AllModels = () => {
const triggerCreate = new URLSearchParams(location.search).get(
"triggerCreate"
);
const [showCreateModelDialogue, setShowCreateModelDialogue] = useState(
triggerCreate === "true" ? true : false
);
const [showCreateModelDialogue, setShowCreateModelDialogue] =
useState(triggerCreate);
const searchRef = useRef(null);

return (
Expand Down Expand Up @@ -77,7 +76,7 @@ export const AllModels = () => {
variant="contained"
size="small"
startIcon={<AddRoundedIcon />}
onClick={() => setShowCreateModelDialogue(true)}
onClick={() => setShowCreateModelDialogue("true")}
data-cy="create-model-button-all-models"
>
Create Model
Expand All @@ -91,9 +90,14 @@ export const AllModels = () => {
/>
</Box>
</Box>
{showCreateModelDialogue && (
{!!showCreateModelDialogue && (
<CreateModelDialogue
onClose={() => setShowCreateModelDialogue(false)}
modelType={
showCreateModelDialogue !== "true"
? showCreateModelDialogue
: undefined
}
onClose={() => setShowCreateModelDialogue("")}
/>
)}
</>
Expand Down
Loading