[Content] Create new item from one to many field #3203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ingle selection when multiselect is disabled
… is not available and conditionally render Copy ZUID menu item
…nhance accessibility with data-cy attributes
…close functionality and conditional rendering
finnar-bin
added
enhancement
agalin920
requested changes
Feb 18, 2025
| }: CreateNewItemDialogProps) => { | ||
| useEffect(() => { | ||
| window.addEventListener(CREATE_NEW_ITEM_DIALOG_EVENTS.CLOSE, onClose); | ||
| window.addEventListener( |
There was a problem hiding this comment.
@finnar-bin are there any alternatives than the custom events and event listener approach. Couldn't we use a Context that can invoke this function?
There was a problem hiding this comment.
Yeah I guess that would work. I could just wrap the entire content app with the context.
There was a problem hiding this comment.
@agalin920 update to use the context api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Phase 2: One to One & One to Many Field - Create & Add New Button #2937
Preview
Screencast.from.02-12-2025.01.36.52.PM.webm