[Content] Handle empty url string #3234
Open
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finnar-bin
added
bug
shrunyan
reviewed
Feb 25, 2025
| @@ -11,6 +11,8 @@ type Props = { | |||
| }; | |||
|
|
|||
| const removeProtocolAndSubdomain = (url: string): string => { | |||
| if (!url) return ""; | |||
There was a problem hiding this comment.
How is this function used? Will it expect an empty string? Should this rather throw an error? i.e. what should the return contract on this function be?
There was a problem hiding this comment.
Also what value was being feed into this function causing the error? Is that value an acceptable value to be provided?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3228