Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Content] Handle empty url string #3234

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[Content] Handle empty url string #3234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/apps/content-editor/src/app/views/Analytics/components/AnalyticsPropertySelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ type Props = {
};

const removeProtocolAndSubdomain = (url: string): string => {
if (!url) return "";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this function used? Will it expect an empty string? Should this rather throw an error? i.e. what should the return contract on this function be?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also what value was being feed into this function causing the error? Is that value an acceptable value to be provided?


const urlObj = new URL(url);
const parts = urlObj.hostname.split(".");

Expand Down
Loading