Skip to content

[Question]: Why does the login UI need to be aware of each kind of external IdP? #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshdcu opened this issue Mar 20, 2025 · 2 comments
Labels
login Login Application question Further information is requested

Comments

@joshdcu
Copy link

joshdcu commented Mar 20, 2025

Hi team, I understand this Typescript login UI is the new login UI and is intended to replace the current login UI within Zitadel Core.

I expect that the Typescript login UI has to follow a similar approach to the one recommended for developing a custom login UI. When the custom login UI integrates with an external IdP, it simply needs to start the provider flow and Zitadel handles the user authentication to the external IdP. In other words, the custom login UI does not need to be aware of the specifics of the external IdP (Google, GitHub, LDAP, SAML, etc.).

However, I see in the feature list, support for each external IdP is specifically mentioned with support for some external IdP's still under progress.

Why does the Typescript login UI need to be aware of and support each external IdP when this external IdP integration/authentication is abstracted away by Zitadel?

@joshdcu joshdcu changed the title [Question]: Why do we need to take care of each kind of external IdP? [Question]: Why does the login UI need to be aware of each kind of external IdP? Mar 20, 2025
@muhlemmer muhlemmer added question Further information is requested login Login Application labels Mar 20, 2025
@muhlemmer muhlemmer moved this to 🧐 Investigating in Product Management Mar 20, 2025
@peintnermax
Copy link
Member

Hi @joshdcu,

You are right with being Zitadel Core to be handling the flow. We've recently changed this by extending the API of the IDP Intent to contain the mapped user information fields.
The limiting factor atm is only rendering the IDP Buttons https://github.com/zitadel/typescript/blob/main/apps/login/src/components/sign-in-with-idp.tsx
This can and will be extended to support unknown IDP configurations by falling back to the SignInWithGeneric component soon.

@joshdcu
Copy link
Author

joshdcu commented Apr 25, 2025

Thank you for the clarification, @peintnermax! I appreciate it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
login Login Application question Further information is requested
Projects
Status: 🧐 Investigating
Development

No branches or pull requests

3 participants