Fix error handling of VirtualMachine actions (stolostron#3972)

* Fix error handling of VirtualMachine actions

Signed-off-by: zlayne <zlayne@redhat.com>

* update test

Signed-off-by: zlayne <zlayne@redhat.com>

---------

Signed-off-by: zlayne <zlayne@redhat.com>

Author: zlayne

backend/src/lib/json-request.ts

@@ -76,15 +76,32 @@ export function jsonPut(url: string, body: unknown, token?: string): Promise<Put
     compress: true,
   })
     .then(async (response) => {
-      try {
-        const resBody = (await response.json()) as unknown
-        return {
-          statusCode: response.status,
-          body: resBody,
+      let responseData = undefined
+      if (response.headers.get('content-type')?.includes('text/plain')) {
+        try {
+          responseData = await response.text()
+          return {
+            statusCode: response.status,
+            body: responseData,
+          }
+        } catch (err) {
+          return {
+            statusCode: response.status,
+            body: 'Error getting resource text response.',
+          }
         }
-      } catch (err) {
-        return {
-          statusCode: response.status,
+      } else {
+        try {
+          responseData = (await response.json()) as unknown
+          return {
+            statusCode: response.status,
+            body: responseData,
+          }
+        } catch (err) {
+          return {
+            statusCode: response.status,
+            body: 'Error getting resource json response.',
+          }
         }
       }
     })

backend/src/routes/virtualMachineProxy.ts

@@ -97,12 +97,12 @@ export async function virtualMachineProxy(req: Http2ServerRequest, res: Http2Ser
               } else {
                 logger.error({
                   msg: 'Error in VirtualMachine action response',
-                  error: results.body.message,
+                  error: results.body?.message ?? '',
                 })
                 res.setHeader('Content-Type', 'application/json')
                 res.writeHead(results.statusCode ?? HTTP_STATUS_INTERNAL_SERVER_ERROR)
                 delete results.body?.code // code is added via writeHead
-                res.end(JSON.stringify(results.body))
+                res.end(JSON.stringify(results.body ?? ''))
               }
             })
             .catch((err: Error) => {

backend/test/routes/virtualMachineProxy.test.ts

@@ -1,9 +1,14 @@
 /* Copyright Contributors to the Open Cluster Management project */
+import { constants } from 'http2'
 import nock from 'nock'
 import { parsePipedJsonBody } from '../../src/lib/body-parser'
 import { request } from '../mock-request'
 
 describe('Virtual Machine actions', function () {
+  afterEach(() => {
+    nock.cleanAll()
+  })
+
   it('should successfully call start action', async function () {
     nock(process.env.CLUSTER_API_URL).get('/apis').reply(200)
     nock(process.env.CLUSTER_API_URL)
@@ -191,4 +196,76 @@ describe('Virtual Machine actions', function () {
     })
     expect(res.statusCode).toEqual(500)
   })
+
+  it('should fail with 502 - content type text/plain error', async function () {
+    nock(process.env.CLUSTER_API_URL).get('/apis').reply(200)
+    nock(process.env.CLUSTER_API_URL)
+      .post(
+        '/apis/authorization.k8s.io/v1/selfsubjectaccessreviews',
+        '{"apiVersion":"authorization.k8s.io/v1","kind":"SelfSubjectAccessReview","metadata":{},"spec":{"resourceAttributes":{"group":"action.open-cluster-management.io","namespace":"testCluster","resource":"managedclusteractions","verb":"create"}}}'
+      )
+      .reply(200, {
+        status: {
+          allowed: true,
+        },
+      })
+    nock(process.env.CLUSTER_API_URL)
+      .get('/api/v1/namespaces/testCluster/secrets')
+      .reply(200, {
+        statusCode: 200,
+        apiVersion: 'v1',
+        kind: 'SecretList',
+        items: [
+          {
+            kind: 'Secret',
+            apiVersion: 'v1',
+            metadata: {
+              name: 'vm-actor',
+              namespace: 'testCluster',
+            },
+            data: {
+              // test-vm-token
+              token: 'dGVzdC12bS10b2tlbg==', // notsecret
+            },
+            type: 'Opaque',
+          },
+        ],
+      })
+    nock(process.env.CLUSTER_API_URL)
+      .get('/apis/route.openshift.io/v1/namespaces/multicluster-engine/routes/cluster-proxy-addon-user')
+      .reply(200, {
+        kind: 'Route',
+        apiVersion: 'route.openshift.io/v1',
+        metadata: {
+          name: 'cluster-proxy-addon-user',
+          namespace: 'multicluster-engine',
+        },
+        spec: {
+          host: 'testCluster.red-chesterfield.com',
+          to: {
+            kind: 'Service',
+            name: 'cluster-proxy-addon-user',
+            weight: 100,
+          },
+          port: {
+            targetPort: 'user-port',
+          },
+          tls: {
+            termination: 'reencrypt',
+            insecureEdgeTerminationPolicy: 'Redirect',
+          },
+          wildcardPolicy: 'None',
+        },
+      })
+    nock('https://testcluster.red-chesterfield.com')
+      .put('/testCluster/apis/subresources.kubevirt.io/v1/namespaces/vmNamespace/virtualmachines/vmName/start')
+      .reply(502, 'plain text error', { [constants.HTTP2_HEADER_CONTENT_TYPE]: ['text/plain'] })
+    const res = await request('PUT', '/virtualmachines/start', {
+      managedCluster: 'testCluster',
+      vmName: 'vmName',
+      vmNamespace: 'vmNamespace',
+    })
+    expect(res.statusCode).toEqual(502)
+    expect(await parsePipedJsonBody(res)).toEqual('plain text error')
+  })
 })