Remove globalSearchFeatureFlag flag if no longer present in configmap (stolostron#3538)

Signed-off-by: zlayne <zlayne@redhat.com>

Author: zlayne

backend/src/lib/config.ts

@@ -45,11 +45,15 @@ export async function loadConfigSettings(): Promise<void> {
     for (const key in settings) {
       if (key.startsWith('LOG_')) {
         process.env[key] = settings[key]
-      } else if (key === 'searchApiEnpoint' || key === 'globalSearchFeatureFlag') {
-        // 2.9 Federated search-api use will be restricted to user defined env variable.
+      } else if (key === 'globalSearchFeatureFlag') {
+        // Global search tech-preview requires feature flag toggle (2.11)
         process.env[key] = settings[key]
       }
     }
+    if (process.env['globalSearchFeatureFlag'] && !settings['globalSearchFeatureFlag']) {
+      // If globalSearchFeatureFlag is set but has been removed from config settings -> removing env var.
+      delete process.env['globalSearchFeatureFlag']
+    }
     if (settings.LOG_LEVEL) {
       logger.level = settings.LOG_LEVEL
     }

backend/src/routes/search.ts

@@ -30,9 +30,7 @@ export async function search(req: Http2ServerRequest, res: Http2ServerResponse):
     const searchService = `https://search-search-api.${mch?.metadata?.namespace || namespace}.svc.cluster.local:4010`
 
     const searchUrl = process.env.SEARCH_API_URL || searchService
-    const endpoint =
-      process.env.searchApiEnpoint ||
-      (process.env.globalSearchFeatureFlag === 'enabled' ? '/federated' : '/searchapi/graphql')
+    const endpoint = process.env.globalSearchFeatureFlag === 'enabled' ? '/federated' : '/searchapi/graphql'
     const url = new URL(searchUrl + endpoint)
     headers.authorization = `Bearer ${token}`
     headers.host = url.hostname