Use kubevirt error message on VM action error (stolostron#3901)

* Use kubevirt error message on VM action error

Signed-off-by: zlayne <zlayne@redhat.com>

* Better unauthorized message

Signed-off-by: zlayne <zlayne@redhat.com>

* update console error namsepace

Signed-off-by: zlayne <zlayne@redhat.com>

* update test

Signed-off-by: zlayne <zlayne@redhat.com>

---------

Signed-off-by: zlayne <zlayne@redhat.com>

Author: zlayne

backend/src/lib/json-request.ts

@@ -27,8 +27,11 @@ export interface PostResponse<T> {
 export interface PutResponse {
   statusCode?: number
   body?: {
+    kind?: string
     name?: string
     message?: string
+    reason?: string
+    code?: number
   }
 }
 

backend/src/routes/virtualMachineProxy.ts

@@ -46,7 +46,7 @@ export async function virtualMachineProxy(req: Http2ServerRequest, res: Http2Ser
             return Buffer.from(proxyToken, 'base64').toString('ascii')
           })
           .catch((err: Error): undefined => {
-            logger.error({ msg: `Error getting secret in namespace bare-metal`, error: err.message })
+            logger.error({ msg: `Error getting secret in namespace ${body.managedCluster}`, error: err.message })
             return undefined
           })
 
@@ -86,7 +86,10 @@ export async function virtualMachineProxy(req: Http2ServerRequest, res: Http2Ser
                 msg: 'Error in VirtualMachine action response',
                 error: results.body.message,
               })
-              res.writeHead(results.statusCode ?? HTTP_STATUS_INTERNAL_SERVER_ERROR).end(JSON.stringify(results))
+              res.setHeader('Content-Type', 'application/json')
+              res.writeHead(results.statusCode ?? HTTP_STATUS_INTERNAL_SERVER_ERROR)
+              delete results.body?.code // code is added via writeHead
+              res.end(JSON.stringify(results.body))
             }
           })
           .catch((err: Error) => {

backend/test/routes/virtualMachineProxy.test.ts

@@ -131,11 +131,8 @@ describe('Virtual Machine actions', function () {
     expect(res.statusCode).toEqual(500)
     expect(JSON.stringify(await parsePipedJsonBody(res))).toEqual(
       JSON.stringify({
-        statusCode: 500,
-        body: {
-          name: 'fetchError',
-          message: 'error testing...',
-        },
+        name: 'fetchError',
+        message: 'error testing...',
       })
     )
   })

frontend/public/locales/en/translation.json

@@ -1364,7 +1364,6 @@
   "error": "Error",
   "Error": "Error",
   "Error getting Ansible jobs": "Error getting Ansible jobs",
-  "Error occurred on VirtualMachine {{name}} {{action}} action.": "Error occurred on VirtualMachine {{name}} {{action}} action.",
   "Error occurred while contacting the search service.": "Error occurred while contacting the search service.",
   "Error occurred while getting the result count.": "Error occurred while getting the result count.",
   "Error occurred while querying for search results. Please try the export again.": "Error occurred while querying for search results. Please try the export again.",
@@ -1373,6 +1372,7 @@
   "Error querying for VirtualMachines": "Error querying for VirtualMachines",
   "Error querying resource logs:": "Error querying resource logs:",
   "Error querying search results": "Error querying search results",
+  "Error triggering action {{action}} on VirtualMachine {{name}}": "Error triggering action {{action}} on VirtualMachine {{name}}",
   "error.create.syntax": "Syntax error: {{0}}",
   "Etcd storage class": "Etcd storage class",
   "Ev3-series": "Ev3-series",
@@ -3047,6 +3047,7 @@
   "Unable to communicate with the server due to a gateway timeout.": "Unable to communicate with the server due to a gateway timeout.",
   "Unable to update the resource because of a resource conflict.": "Unable to update the resource because of a resource conflict.",
   "Unauthorized": "Unauthorized",
+  "Unauthorized to execute this action.": "Unauthorized to execute this action.",
   "unavailable": "unavailable",
   "Unavailable": "Unavailable",
   "unbind": "Remove from cluster",
@@ -3067,7 +3068,6 @@
   "unknown: {{count}} cluster_plural": "unknown: {{count}} clusters",
   "Unpause {{resourceKind}}": "Unpause {{resourceKind}}",
   "Unprocessable entity": "Unprocessable entity",
-  "Unsuccessful request": "Unsuccessful request",
   "update": "Update",
   "Update automation template": "Update automation template",
   "Update risk predictions": "Update risk predictions",

frontend/src/routes/Search/SearchResults/utils.tsx

@@ -54,12 +54,16 @@ export function handleVMActions(
     })
     .catch((err) => {
       console.error(`VirtualMachine: ${item.name} ${action} error. ${err}`)
+
+      let errMessage = err?.message ?? t('An unexpected error occurred.')
+      if (errMessage.includes(':')) errMessage = errMessage.split(':')[1]
+      if (errMessage === 'Unauthorized') errMessage = t('Unauthorized to execute this action.')
       toast.addAlert({
-        title: err?.message ?? t('Unsuccessful request'),
-        message: t('Error occurred on VirtualMachine {{name}} {{action}} action.', {
+        title: t('Error triggering action {{action}} on VirtualMachine {{name}}', {
           name: item.name,
           action,
         }),
+        message: errMessage,
         type: 'danger',
       })
     })