Skip to content

Commit a264525

Browse files
authoredMar 11, 2024
ACM-10339 Show syntax errors on save in search YAML editor (stolostron#3346)
Signed-off-by: zlayne <zlayne@redhat.com>
1 parent 22fae8d commit a264525

File tree

1 file changed

+17
-9
lines changed

1 file changed

+17
-9
lines changed
 

‎frontend/src/routes/Home/Search/Details/YAMLPage.tsx

+17-9
Original file line numberDiff line numberDiff line change
@@ -89,15 +89,21 @@ function updateResource(
8989
setResourceVersion: Dispatch<SetStateAction<string>>
9090
) {
9191
if (cluster === 'local-cluster') {
92-
replaceResource(jsYaml.load(resourceYaml) as IResource)
93-
.promise.then(() => {
94-
loadResource(cluster, kind, apiversion, name, namespace, setResourceYaml, setUpdateError, setResourceVersion)
95-
setUpdateSuccess(true)
96-
})
97-
.catch((err) => {
98-
console.error('Error updating resource: ', err)
99-
setUpdateError(err.message)
100-
})
92+
try {
93+
const parsedYaml = jsYaml.load(resourceYaml) as IResource
94+
replaceResource(parsedYaml)
95+
.promise.then(() => {
96+
loadResource(cluster, kind, apiversion, name, namespace, setResourceYaml, setUpdateError, setResourceVersion)
97+
setUpdateSuccess(true)
98+
})
99+
.catch((err) => {
100+
console.error('Error updating resource: ', err)
101+
setUpdateError(err.message)
102+
})
103+
} catch (err: any) {
104+
console.error('Error updating resource: ', err)
105+
setUpdateError(err?.message)
106+
}
101107
} else {
102108
fireManagedClusterAction('Update', cluster, kind, apiversion, name, namespace, jsYaml.loadAll(resourceYaml)[0])
103109
.then((actionResponse) => {
@@ -211,6 +217,8 @@ export function EditorActionBar(props: {
211217
variant="primary"
212218
id="update-resource-button"
213219
onClick={() => {
220+
setUpdateError('')
221+
setUpdateSuccess(false)
214222
updateResource(
215223
cluster,
216224
kind,

0 commit comments

Comments
 (0)
Failed to load comments.