Remove Compliance wording messages from GRC UI pages (stolostron#3651)

Ref: https://issues.redhat.com/browse/ACM-11787

Signed-off-by: yiraeChristineKim <yikim@redhat.com>

Author: yiraeChristineKim

frontend/public/locales/en/translation.json

@@ -328,7 +328,7 @@
   "A placement selects clusters from the cluster sets which have bindings to the resource namespace.": "A placement selects clusters from the cluster sets which have bindings to the resource namespace.",
   "A placement without any label selectors or label expressions will select all clusters.": "A placement without any label selectors or label expressions will select all clusters.",
   "A policy contains  policy templates that create policies on managed clusters.": "A policy contains  policy templates that create policies on managed clusters.",
-  "A policy generates reports and validates cluster compliance based on specified security standards, categories, and controls.": "A policy generates reports and validates cluster compliance based on specified security standards, categories, and controls.",
+  "A policy generates reports and validates cluster violations based on specified security standards, categories, and controls.": "A policy generates reports and validates cluster violations based on specified security standards, categories, and controls.",
   "A project organizes all of your Google Cloud resources. A project consists of a set of users; a set of APIs; and billing, authentication, and monitoring settings for those APIs. So, for example, all of your Cloud Storage buckets and objects, along with user permissions for accessing them, reside in a project.": "A project organizes all of your Google Cloud resources. A project consists of a set of users; a set of APIs; and billing, authentication, and monitoring settings for those APIs. So, for example, all of your Cloud Storage buckets and objects, along with user permissions for accessing them, reside in a project.",
   "A proxy URL to use for creating HTTP connections outside the cluster. The URL scheme must be HTTP.": "A proxy URL to use for creating HTTP connections outside the cluster. The URL scheme must be HTTP.",
   "A proxy URL to use for creating HTTPS connections outside the cluster. If this is not specified, then httpProxy is used for both HTTP and HTTPS connections.": "A proxy URL to use for creating HTTPS connections outside the cluster. If this is not specified, then httpProxy is used for both HTTP and HTTPS connections.",
@@ -659,7 +659,6 @@
   "Cluster 2": "Cluster 2",
   "Cluster add-ons": "Cluster add-ons",
   "Cluster claim expressions": "Cluster claim expressions",
-  "Cluster compliance": "Cluster compliance",
   "Cluster Conditions": "Cluster Conditions",
   "Cluster decision resource requeue time in seconds": "Cluster decision resource requeue time in seconds",
   "Cluster deploy status": "Cluster deploy status",
@@ -763,7 +762,6 @@
   "Compare application types": "Compare application types",
   "Compare control plane types": "Compare control plane types",
   "Completions": "Completions",
-  "Compliant": "Compliant",
   "components": "components",
   "Compute core": "Compute core",
   "Compute memory": "Compute memory",

frontend/src/routes/Governance/policies/Policies.test.tsx

@@ -61,7 +61,7 @@ describe('Policies Page', () => {
     await waitForText(mockPolicy[0].metadata.name!)
 
     // Sorting
-    screen.getByRole('button', { name: 'Cluster compliance' }).click()
+    screen.getByRole('button', { name: 'Cluster violations' }).click()
     screen.getByRole('button', { name: 'Namespace' }).click()
     screen.getByRole('button', { name: 'Name' }).click()
 
@@ -89,7 +89,7 @@ describe('Policies Page', () => {
     await waitForText('Name')
     await waitForText('Namespace')
     await waitForText('Remediation')
-    await waitForText('Cluster compliance')
+    await waitForText('Cluster violations')
     await waitForText('Source')
     await waitForText('Policy set')
     expect(screen.queryByRole('columnheader', { name: /Status/ })).not.toBeInTheDocument()
@@ -230,7 +230,7 @@ describe('Policies Page', () => {
         '/multicloud/governance/policy-sets?search%3D%7B%22name%22%3A%5B%22policy-set-with-1-placement%22%5D%2C%22namespace%22%3A%5B%22test%22%5D%7D'
       )
     )
-    // Verify the Cluster compliance column has the correct link to policy details page
+    // Verify the Cluster violations column has the correct link to policy details page
     await waitFor(() =>
       // need to use index [1] because the name column is also an "a" element
       expect(container.querySelectorAll('a')[2]).toHaveAttribute(

frontend/src/routes/Governance/policies/Policies.tsx

@@ -531,7 +531,7 @@ export default function PoliciesPage() {
     () => [
       {
         id: 'violations',
-        label: 'Cluster compliance',
+        label: 'Cluster violations',
         options: [
           {
             label: t('Without violations'),
@@ -772,7 +772,7 @@ function usePolicyViolationsColumn(
 ): IAcmTableColumn<PolicyTableItem> {
   const { t } = useTranslation()
   return {
-    header: t('Cluster compliance'),
+    header: t('Cluster violations'),
     cell: (item) => {
       const clusterViolationSummary = policyClusterViolationSummaryMap[item.policy.metadata.uid ?? '']
       if (

frontend/src/routes/Governance/policies/policy-details/PolicyTemplateDetails.tsx

@@ -120,7 +120,7 @@ export function PolicyTemplateDetails(
       value: template?.apiVersion ?? '-',
     },
     {
-      key: t('Compliant'),
+      key: t('Violations'),
       value: template?.status?.compliant ?? '-',
     },
     {
@@ -156,7 +156,7 @@ export function PolicyTemplateDetails(
         search: 'object.apiVersion',
       },
       {
-        header: t('Compliant'),
+        header: t('Violations'),
         sort: (a: any, b: any) => compareStrings(a.compliant, b.compliant),
         cell: (item: any) => {
           let compliant = item.compliant ?? '-'

frontend/src/routes/Home/Overview/OverviewPage.test.tsx

@@ -1183,7 +1183,7 @@ it('should render overview page with expected data', async () => {
   await waitFor(() => expect(getAllByText('Amazon')).toHaveLength(1))
   await waitFor(() => expect(getAllByText('Microsoft')).toHaveLength(1))
 
-  // Check Cluster compliance chart rendered
+  // Check Cluster violations chart rendered
   await waitFor(() => expect(getAllByText('Cluster violations')).toHaveLength(2))
   await waitFor(() => expect(getByText('1 Without violations')).toBeTruthy())
   await waitFor(() => expect(getByText('1 With violations')).toBeTruthy())

frontend/src/ui-components/AcmCharts/AcmDonutChart/AcmDonutChart.stories.tsx

@@ -48,7 +48,7 @@ export const DonutChart = () => {
     <BrowserRouter>
       <AcmChartGroup>
         <AcmDonutChart
-          title="Cluster compliance"
+          title="Cluster violations"
           description="Overview of policy compliance status"
           data={complianceData}
         />
@@ -72,7 +72,7 @@ export const DonutChart = () => {
 export const DonutChartSkeleton = () => {
   return (
     <AcmChartGroup>
-      <AcmDonutChart loading={true} title="Cluster compliance" description="Policy compliance" data={[]} />
+      <AcmDonutChart loading={true} title="Cluster violations" description="Policy compliance" data={[]} />
       <AcmDonutChart loading={true} title="Pods" description="Overview of pod count and status" data={[]} />
       <AcmDonutChart loading={true} title="Cluster status" description="Overview of cluster status" data={[]} />
     </AcmChartGroup>

frontend/src/ui-components/AcmCharts/AcmDonutChart/AcmDonutChart.test.tsx

@@ -21,26 +21,26 @@ const podData = [
 
 describe('AcmDonutChart', () => {
   test('renders', () => {
-    const { getByRole, getByTestId } = render(
+    const { queryAllByText } = render(
       <MemoryRouter>
         <AcmDonutChart
-          title="Cluster compliance"
-          description="Overview of policy compliance status"
+          title="Cluster violations"
+          description="Overview of policy violations status"
           data={complianceData}
         />
       </MemoryRouter>
     )
-    expect(getByTestId('cluster-compliance-chart')).toBeInTheDocument()
-    expect(getByRole('link')).toBeInTheDocument()
+
+    expect(queryAllByText('Cluster violations').length).toBeGreaterThan(0)
   })
 
   test('renders skeleton', () => {
     const { queryByText } = render(
       <MemoryRouter>
-        <AcmDonutChart loading={true} title="Cluster compliance" description="Policy compliance" data={[]} />
+        <AcmDonutChart loading={true} title="Cluster violations" description="Policy violations" data={[]} />
       </MemoryRouter>
     )
-    expect(queryByText('Cluster compliance')).toBeInTheDocument()
+    expect(queryByText('Cluster violations')).toBeInTheDocument()
   })
 
   test('renders with zero values state', () => {

frontend/src/wizards/Governance/Policy/PolicyWizard.tsx

@@ -93,7 +93,7 @@ export function PolicyWizard(props: {
       title={props.title}
       breadcrumb={props.breadcrumb}
       description={t(
-        'A policy generates reports and validates cluster compliance based on specified security standards, categories, and controls.'
+        'A policy generates reports and validates cluster violations based on specified security standards, categories, and controls.'
       )}
       yamlEditor={props.yamlEditor}
       onSubmit={props.onSubmit}