Upgrade risk widget should show total clusters with risk not percent (stolostron#3713)

Signed-off-by: zlayne <zlayne@redhat.com>

Author: zlayne

frontend/public/locales/en/translation.json

@@ -680,6 +680,7 @@
   "Cluster landscape": "Cluster landscape",
   "Cluster list": "Cluster list",
   "Cluster name": "Cluster name",
+  "cluster needs to be reviewed before updating": "cluster needs to be reviewed before updating",
   "Cluster network host prefix": "Cluster network host prefix",
   "Cluster node pools": "Cluster node pools",
   "Cluster OS image": "Cluster OS image",
@@ -745,6 +746,7 @@
   "clusterPools": "Cluster pools",
   "Clusters": "Clusters",
   "clusters affected": "clusters affected",
+  "clusters need to be reviewed before updating": "clusters need to be reviewed before updating",
   "Clusters with pending policies": "Clusters with pending policies",
   "Clusters with policy violations": "Clusters with policy violations",
   "Clusters without policy violations": "Clusters without policy violations",

frontend/src/routes/Home/Overview/OverviewPageBeta.tsx

@@ -216,7 +216,7 @@ export default function OverviewPageBeta(props: { selectedClusterLabels: Record<
     }
   }, [managedClusterIds])
 
-  const { criticalUpdateCount, warningUpdateCount, infoUpdateCount, percentOfClustersWithRisk } = useMemo(() => {
+  const { criticalUpdateCount, warningUpdateCount, infoUpdateCount, clustersWithRiskPredictors } = useMemo(() => {
     const reducedUpgradeRiskPredictions = upgradeRiskPredictions.reduce((acc: any[], curr: any) => {
       if (curr.body && curr.body.predictions) {
         return [...acc, ...curr.body.predictions]
@@ -451,8 +451,11 @@ export default function OverviewPageBeta(props: { selectedClusterLabels: Record<
                       </Popover>
                     }
                     summaryTotalHeader={{
-                      num: `${percentOfClustersWithRisk}%`,
-                      text: 'of clusters need to be reviewed before updating',
+                      num: `${clustersWithRiskPredictors}`,
+                      text:
+                        clustersWithRiskPredictors === 1
+                          ? t('cluster needs to be reviewed before updating')
+                          : t('clusters need to be reviewed before updating'),
                     }}
                     summaryData={[
                       { icon: <CriticalRiskIcon />, label: t('Critical'), count: criticalUpdateCount },

frontend/src/routes/Home/Overview/__snapshots__/overviewDataFunctions.test.tsx.snap

@@ -168,18 +168,18 @@ Object {
 
 exports[`Correctly returns parseUpgradeRiskPredictions with no predictions 1`] = `
 Object {
+  "clustersWithRiskPredictors": 0,
   "criticalUpdateCount": 0,
   "infoUpdateCount": 0,
-  "percentOfClustersWithRisk": 0,
   "warningUpdateCount": 0,
 }
 `;
 
 exports[`Correctly returns parseUpgradeRiskPredictions with predictions 1`] = `
 Object {
+  "clustersWithRiskPredictors": 2,
   "criticalUpdateCount": 1,
   "infoUpdateCount": 1,
-  "percentOfClustersWithRisk": 50,
   "warningUpdateCount": 1,
 }
 `;

frontend/src/routes/Home/Overview/overviewDataFunctions.tsx

@@ -143,13 +143,10 @@ export function parseUpgradeRiskPredictions(upgradeRiskPredictions: any) {
   let criticalUpdateCount = 0
   let warningUpdateCount = 0
   let infoUpdateCount = 0
-  let percentOfClustersWithRisk = 0
-  let totalClusters = 0
   let clustersWithRiskPredictors = 0
 
   if (upgradeRiskPredictions.length > 0) {
     upgradeRiskPredictions.forEach((cluster: any) => {
-      totalClusters++
       if (
         cluster.upgrade_risks_predictors &&
         cluster.upgrade_risks_predictors.alerts &&
@@ -172,14 +169,12 @@ export function parseUpgradeRiskPredictions(upgradeRiskPredictions: any) {
       }
     })
   }
-  if (totalClusters > 0) {
-    percentOfClustersWithRisk = parseFloat(((clustersWithRiskPredictors / totalClusters) * 100).toFixed(1))
-  }
+
   return {
     criticalUpdateCount,
     warningUpdateCount,
     infoUpdateCount,
-    percentOfClustersWithRisk,
+    clustersWithRiskPredictors,
   }
 }