Add habr translator #3428
Merged
Add habr translator #3428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbeJellinek
requested changes
Mar 26, 2025
Habr.js
Outdated
| const date = attr(doc, 'meta[property="aiturec:datetime"]', 'content'); | ||
| item.date = ZU.strToISO(date); | ||
|
|
||
| const author = text(doc, 'div.tm-article-presenter__header span.tm-article-snippet__author a.tm-user-info__username'); |
There was a problem hiding this comment.
Way, way too specific. Can we at least remove the tag names? Is .tm-user-info__username by itself not enough?
There was a problem hiding this comment.
.tm-user-info__username is used too many times on page. Specially in comments block. I simplified css selector to .tm-article-presenter__header a.tm-user-info__username (userlink inside header).
AbeJellinek
reviewed
Mar 26, 2025
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add translator for habr.com
Based on Embedded Metadata. Updated fields: