Skip to content

Library Catalog (TIND ILS): Fix record URL and add attachments #3437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 8, 2025
Merged

Library Catalog (TIND ILS): Fix record URL and add attachments #3437

merged 6 commits into from
May 8, 2025

Conversation

skairunner
Copy link
Contributor

@skairunner skairunner commented Mar 28, 2025 •
edited
Loading

  • Add record url to the items more reliably by using OpenGraph metadata
  • Add attached files to the items
  • Tweak the detector to handle some of the cases where it gives a false negative
    • Some sites like https://digitallibrary.un.org/record/4079320 hide the tind footer.
    • This change will still give false negatives on sites with hidden tind footer and no file.
    • TIND plans to add a special span with a well known id to aid in detecting TIND ILS sites in the future, at which point I'll make a new PR to fix the detect web once and for all.

@skairunner skairunner force-pushed the tindils/files branch 3 times, most recently from 16aa2e8 to 6ee6f84 Compare March 28, 2025 09:29
@AbeJellinek AbeJellinek mentioned this pull request Mar 28, 2025
Merged
@skairunner skairunner marked this pull request as draft March 31, 2025 06:51
@skairunner skairunner closed this Mar 31, 2025
@skairunner skairunner reopened this Mar 31, 2025
@skairunner skairunner force-pushed the tindils/files branch 3 times, most recently from 8948d15 to 970ec46 Compare March 31, 2025 07:41
@skairunner skairunner marked this pull request as ready for review March 31, 2025 08:02
AbeJellinek added 5 commits May 8, 2025 11:33
@AbeJellinek
Revert doWeb() changes
ff6d5a8 
We generally try to keep multiples requests sequential, and scrape()
doesn't take a second argument.
@AbeJellinek
Simplify getFileInformation()
4cedfa0 
- We check for #detailed-file-api-args in detectWeb()
- Use global requestJSON()
- URLSearchParams takes an object
- Log error
@AbeJellinek
Delete "No abstract" abstract
33a12b3
@AbeJellinek
Simplify og:url routine
181f491
@AbeJellinek
Update test
51d088e
@AbeJellinek AbeJellinek merged commit 332bba8 into zotero:master May 8, 2025
1 check failed
@AbeJellinek
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skairunner @AbeJellinek @thms-rmb