Skip to content

Commit 58f3116

Browse files
committed
fix incorrect feature size calculation
1 parent 3724d5f commit 58f3116

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

vllm/model_executor/models/llava_next.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -87,17 +87,19 @@ def _get_llava_next_num_unpadded_features(
8787
current_height = npatches * num_patch_height
8888
current_width = npatches * num_patch_width
8989

90-
aspect_ratio = original_width / original_height
90+
original_aspect_ratio = original_width / original_height
9191
current_aspect_ratio = current_width / current_height
9292

93-
if aspect_ratio > current_aspect_ratio:
94-
new_height = (original_height * current_width) // original_width
93+
if original_aspect_ratio > current_aspect_ratio:
94+
scale_factor = current_width / original_width
95+
new_height = int(original_height * scale_factor)
9596
padding = (current_height - new_height) // 2
96-
current_height -= padding * 2
97+
current_height -= 2 * padding
9798
else:
98-
new_width = (original_width * current_height) // original_height
99+
scale_factor = current_height / original_height
100+
new_width = int(original_width * scale_factor)
99101
padding = (current_width - new_width) // 2
100-
current_width -= padding * 2
102+
current_width -= 2 * padding
101103

102104
unpadded_features = current_height * current_width
103105
newline_features = current_height

0 commit comments

Comments
 (0)