Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loop #38

Open
grimace opened this issue May 1, 2017 · 12 comments
Open

Infinite loop #38

grimace opened this issue May 1, 2017 · 12 comments

Comments

@grimace
Copy link

grimace commented May 1, 2017

I couldn't find it in the documentation, but I'm sure I might have missed something.

@ihadeed
Copy link
Member

ihadeed commented May 1, 2017

Not sure what you mean by wrap around left or right

@grimace
Copy link
Author

grimace commented May 1, 2017

If I have 5 tabs and I get to the far left and swipe left, go to the one on the far right. i.e. tab4<-tab0 or tab4->tab0. or like 4,0,1,2,3,4,0.

@ihadeed
Copy link
Member

ihadeed commented May 1, 2017

Sorry @grimace, I'm still not able to understand your question.

Could you please demonstrate it with a video? or provide an example?

@grimace
Copy link
Author

grimace commented May 1, 2017

Sorry for the confusion. How about this?
Let's say you have 3 tabs; Tab1, Tab2, Tab3.

  1. Starting from the left ( Tab1 )
  2. Swipe right to Tab2
  3. Swipe right to Tab3
  4. Continue to swipe right from Tab3 - currently, nothing happens ( of course you could go back the other way, but not what I was looking for )
  5. What I'm interested in is the ability to swipe right from Tab3 ( wrapping back around ) to Tab1. So that you could actually continuously swipe in one direction forever ( or until you get tired of the exercise).

@ihadeed
Copy link
Member

ihadeed commented May 1, 2017

@grimace

oh, so like the loop option on ion-slides ?

There isn't an option for that right now. I should be able to implement it in the near future.

@darron1217
Copy link

@ihadeed I'm expecting for loop option too!
Anyway, thank you for this beautiful plugin :)

@grimace
Copy link
Author

grimace commented May 2, 2017

Yes, exactly what I was looking for. Also like to express my gratitude. Great project. Thanks!

@ihadeed ihadeed changed the title Is there an easy way to wrap around left and right? Infinite loop Mar 28, 2019
@ihadeed ihadeed mentioned this issue Mar 28, 2019
@NgYueHong
Copy link

NgYueHong commented Apr 5, 2019

Really hope to see this feature implemented soon. Although, it's been almost 2 years old request already.

@ihadeed
Copy link
Member

ihadeed commented Apr 7, 2019

@NgYueHong I'll try to implement this if it performs well. The new super tabs is based on a flex box .. so it should be easier to move the tabs around and give the user the feeling of an infinite loop.

@rajabmohammadi
Copy link

@ihadeed
I work on ionic 4 application
but when I loop the super-tab-button and super-tab
I have this error :
core.js:15723 ERROR Error: Uncaught (in promise): TypeError: Cannot set property 'active' of undefined TypeError: Cannot set property 'active' of undefined at SuperTabsToolbarComponent.push../node_modules/@ionic-super-tabs/core/dist/esm/legacy/super-tab-button_2.entry.js.SuperTabsToolbarComponent.markButtonActive (super-tab-button_2.entry.js:249)

@NgYueHong
Copy link

@ihadeed It's great to see that Ionic 4 is now officially supported and I am really looking forward to see this feature implemented soon. With this feature, it will be a HUGE UPGRADE to this plugin that the plugin will be able to be used for infinite page swiping. Just like Gmail app, where user can just continuously swipe to view the next email. Just imagine how much more useful this plugin will be with the implementation of infinite loop feature.

@Foxion7
Copy link

Foxion7 commented Jun 16, 2020

@ihadeed Is there any news on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants