Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add avoid-super-tabs attribute #314

Merged
merged 1 commit into from
Jun 18, 2018
Merged

Add avoid-super-tabs attribute #314

merged 1 commit into from
Jun 18, 2018

Conversation

stionic
Copy link
Contributor

@stionic stionic commented Jun 16, 2018

Hi @ihadeed ,

I have added avoid-super-tabs attribute for avoid swipe event, hope it will helpful.

Regards.

@sfaizanh
Copy link

@stionic have you tested on real device?

@stionic
Copy link
Contributor Author

stionic commented Jun 16, 2018

Hi @sfaizanh

Yes, tested in Android and iOS, work fine.

Regards.

@sfaizanh
Copy link

sfaizanh commented Jun 16, 2018 via email

@ihadeed
Copy link
Member

ihadeed commented Jun 18, 2018

Thanks for the PR @stionic

Could you please provide an code sample to see how this would be used?

@stionic
Copy link
Contributor Author

stionic commented Jun 18, 2018

@ihadeed i

Hi,
Current, if inner super-tab component has ion-scroll horizontal then it will not work because when swipe will change tab instead of scroll.
With this pull request, developers can add avoid-super-tabs attribute for avoid swipe event and can scroll horizontal.

Sample:

<ion-content>
  <ion-scroll scrollX="true" avoid-super-tabs="true">
     <!-- Scroll content, swipe here will not change tab and will scroll -->
  </ion-scroll>
  <ion-row>
     <ion-col>Swipe here will change tab</ion-col>
  </ion-row>
</ion-content>

Regards.

@ihadeed
Copy link
Member

ihadeed commented Jun 18, 2018

Great thanks! this is awesome.

@ihadeed ihadeed merged commit b7da642 into zyra:master Jun 18, 2018
@srjovanovic
Copy link

Is this attribute implemented in 4.2.2 npm package?

@stionic
Copy link
Contributor Author

stionic commented Jun 23, 2018

@srjovanovic

Hi, lastest version 4.2.2 in NPM package published 5 months ago.
Now maybe you can install this repo by:

npm install https://github.com/zyra/ionic2-super-tabs.git

@srjovanovic
Copy link

@stionic
Thanks

@codebyabhisheknayar
Copy link

how do i install super-tabs with avoid-super-tabs="true" attribute.? I tried with
npm i --save ionic2-super-tabs but avoid-super-tabs not working.

@stionic
Copy link
Contributor Author

stionic commented Jun 30, 2018

@spyman143

Please try:

npm install https://github.com/zyra/ionic2-super-tabs.git

Regards.

@codebyabhisheknayar
Copy link

codebyabhisheknayar commented Jun 30, 2018

i had install with above link, but its removed my supertabs inner folder such as dist from node_modules.

@stionic please help me to solve this

@stionic
Copy link
Contributor Author

stionic commented Jun 30, 2018

Hi,

I have tried npm install from github but not luck,
Best way is wait for @ihadeed release new version.

@stionic
Copy link
Contributor Author

stionic commented Jul 10, 2018

@spyman143

Hi,

Version 4.3.0 released 8 days ago have added this pull request.
You can update now:

npm uninstall ionic2-super-tabs
npm install ionic2-super-tabs

Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants