Skip to content

Support tabDragStart/tabDragStop events. #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

lincolnthree
Copy link
Contributor

Addresses #347 and a few prior, now-closed requests.

Copy link
Member

@ihadeed ihadeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can know exactly when the dragging stopped if we listen to the container events & push it up to the parent.

This approach is still good -- we can merge it and improve later, unless if you would like to implement the idea above.

@lincolnthree
Copy link
Contributor Author

I agree with "We can know exactly when the dragging stopped if we listen to the container events & push it up to the parent."

Actually I think it is necessary as the current approach using timeouts actually kills performance pretty horribly since it's constantly checking and cancelling the timeout. I took this PR originally from one you got a while ago, I'll update with the changes, but... I'm not sure what the best way to push events from container up is. It looks like I'll need to add a hook to the parent in the container, or vis-versa.

Regarding your specific code change requests/comments. I think these are all rendered non-applicable if we change this to use the actual container events, right?

@lincolnthree
Copy link
Contributor Author

Nevermind. The events can just be bound in the template (duh..)

@lincolnthree
Copy link
Contributor Author

Alright. Take a look at this. I think it's pretty clean now. Much more efficient for sure.

I'm not sure of the nuances of your gesture events, so hopefully I put things in the right place. Let me know what you think!

@lincolnthree
Copy link
Contributor Author

hey @ihadeed. Just checking on your thoughts about this PR since update. I have a few more things I might send your way as well if I can get them cleaned up (including a "low graphics" mode") and the ability to pass through lifecycle to the active tab (willEnter, didEnter, willLeave, didLeave) etc.

@ihadeed ihadeed merged commit b3e6c28 into zyra:master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants