View scroll (Depends on PR#353) #354
Conversation
|
This only depends on prior PRs because I didn't go the extra step to separate the features/commits. Busy here :) They can be split if necessary, if you choose not to merge some/all of them. |
|
@lincolnthree Are you using the modified version of the plugin with one of your apps? I would like to give it a try, because the current animations doesn't feel smooth on older android devices... |
|
Yes indeed @svzi. And that's exactly the issue I had. It wasn't even smooth on new devices with moderately complex views in each tab. But leaving the indicator motion seems to be a decent compromise in responsiveness to allow users to know something is going on... It's in the latest release of TopDecked: http://app.topdecked.com No account required. |
|
You can actually turn on viewScroll in the app settings if you want to see the difference (note, it's major.) |
|
@lincolnthree You're totally right about the new devices, I just didn't test it before. I thought it felt so bad because of my old test device (Motorola G4), but even on my Honor 10, it felt really bad. So I downloaded TopDecked on my Honor 10 and it looks really smooth (compared with original version of the plugin) and even on my G4 it's at least okay. I didn't find "viewScroll" in the app settings, you probably mean the "fancy animations"? Is there anyway to contact you directly (maybe the feedback mail address from the Play Store)? |
|
You can use "Help & Feedback" from the app main menu and I'll be able to chat with you directly there. Or the feedback email works too. |
|
@ihadeed When to expect a new version on npm, with the PR merged? |
This PR exposes the option to disable the expensive view-scrolling from onMove events (enables a more traditional tabs experience with a slightly more intuitive UX for swiping/changing tabs). The indicator moves (cheap animation in comparison to translating the entire tabs-container).
Depends on #353